Feat/swap expiry timeout - #96
Merged
fejilaup-cloud merged 2 commits intoMar 26, 2026
Merged
Conversation
- Add expiry: u64 to SwapRecord, set at initiation as ledger timestamp + configurable duration (defaults to DEFAULT_SWAP_DURATION_SECS = 86400s) - initiate_swap gains a duration_secs param; pass 0 for the 24h default - Add cancel_expired_swap: only the buyer may call it, only on an Accepted swap, and only after the expiry timestamp has passed; panics otherwise - cancel_swap now restricted to Pending-only to keep semantics clean - Add tests: - test_cancel_expired_swap_after_timeout: full happy-path expiry flow - test_cancel_expired_swap_before_timeout_panics - test_cancel_expired_swap_non_buyer_panics - test_cancel_expired_swap_on_pending_panics - test_reveal_key_before_expiry_completes_swap: existing flow unaffected
|
@graycioustukura-sketch Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #19